[commit: ghc] master: validate: enable -DDEBUG in stage 1 by default (66fa0ed)

git at git.haskell.org git at git.haskell.org
Sun Feb 7 18:14:12 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/66fa0ed7087588b9c1577f44836f712f093089c1/ghc

>---------------------------------------------------------------

commit 66fa0ed7087588b9c1577f44836f712f093089c1
Author: Ömer Sinan Ağacan <omeragacan at gmail.com>
Date:   Sun Feb 7 13:14:44 2016 -0500

    validate: enable -DDEBUG in stage 1 by default
    
    Since the whole point of validation is to test the compiler, assertions
    should be enabled at least for some part of the build. Previously
    assertions were only enabled (1) in stage 2 compiler (2) when "slow"
    setting is used. With this patch we enable assertions in stage 1
    compiler in all settings, to test them on (1) the compiler itself (2)
    the libraries, even with the "fast" setting.
    
    This will make "fast" setting slower, but the difference should be quite
    modest - I didn't realize a significant difference in validation times.
    
    Reviewers: bgamari, austin, thomie
    
    Reviewed By: thomie
    
    Differential Revision: https://phabricator.haskell.org/D1890


>---------------------------------------------------------------

66fa0ed7087588b9c1577f44836f712f093089c1
 mk/flavours/validate.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/flavours/validate.mk b/mk/flavours/validate.mk
index 1a636fa..cb38bd5 100644
--- a/mk/flavours/validate.mk
+++ b/mk/flavours/validate.mk
@@ -1,6 +1,6 @@
 SRC_HC_OPTS        = -O0 -H64m
 SRC_HC_OPTS_STAGE1 = -fllvm-fill-undef-with-garbage   # See Trac 11487
-GhcStage1HcOpts    = -O
+GhcStage1HcOpts    = -O -DDEBUG
 GhcStage2HcOpts    = -O -dcore-lint
 GhcLibHcOpts       = -O -dcore-lint
 BUILD_PROF_LIBS    = NO



More information about the ghc-commits mailing list