[commit: ghc] master: Rename TH constructors for deriving strategies (5349d64)

git at git.haskell.org git at git.haskell.org
Fri Dec 9 22:04:13 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/5349d648fd7af3f50953e8594b3d148ab073017f/ghc

>---------------------------------------------------------------

commit 5349d648fd7af3f50953e8594b3d148ab073017f
Author: Ryan Scott <ryan.gl.scott at gmail.com>
Date:   Fri Dec 9 15:44:15 2016 -0500

    Rename TH constructors for deriving strategies
    
    After talking to Richard, he and I concluded that choosing the rather
    common name `Newtype` to represent the corresponding deriving strategy
    in Template Haskell was a poor choice of name. I've opted to rename it
    to something less common (`NewtypeStrategy`) while we still have time. I
    also renamed the corrsponding datatype in the GHC internals so as to
    match it.
    
    Reviewers: austin, goldfire, hvr, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: thomie, mpickering
    
    Differential Revision: https://phabricator.haskell.org/D2814
    
    GHC Trac Issues: #10598


>---------------------------------------------------------------

5349d648fd7af3f50953e8594b3d148ab073017f
 compiler/basicTypes/BasicTypes.hs                    | 19 ++++++++++---------
 compiler/deSugar/DsMeta.hs                           |  6 +++---
 compiler/hsSyn/Convert.hs                            |  6 +++---
 compiler/parser/Parser.y                             |  6 +++---
 compiler/prelude/THNames.hs                          | 12 +++++++-----
 compiler/typecheck/TcDeriv.hs                        | 20 ++++++++++----------
 compiler/typecheck/TcDerivUtils.hs                   |  6 +++---
 .../template-haskell/Language/Haskell/TH/Ppr.hs      |  6 +++---
 .../template-haskell/Language/Haskell/TH/Syntax.hs   |  6 +++---
 testsuite/tests/th/T10598_TH.hs                      | 12 ++++++------
 testsuite/tests/th/T10598_TH.stderr                  | 12 ++++++------
 11 files changed, 57 insertions(+), 54 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 5349d648fd7af3f50953e8594b3d148ab073017f


More information about the ghc-commits mailing list