[commit: ghc] master: Kill redundant import (da58d15)

git at git.haskell.org git at git.haskell.org
Fri Oct 30 11:27:30 UTC 2015


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/da58d1517ce9c57514f7b2bd7d444c9e3051a717/ghc

>---------------------------------------------------------------

commit da58d1517ce9c57514f7b2bd7d444c9e3051a717
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Fri Oct 30 09:45:16 2015 +0000

    Kill redundant import
    
    I don't really understand this.  GHC.hs had:
    
      module GHC( ...,  module HsSyn, ... ) where
        import HsSyn
        import qualified HsSyn -- hack as we want to reexport the whole module
    
    GHC now reports the 'import qualified' line as redundant; and it certainly
    is, because 'import HsSyn' brings everything into scope qualified *and*
    unqualified.   I have no idea why the "hack" was necessary before, but
    following my refactoring of tcg_used_gres (previous commit), it's reported
    as redundant, so I've deleted it.
    
    I'm making it a separate commit because it seems a bit mysterious and I
    wanted to draw attention to it.


>---------------------------------------------------------------

da58d1517ce9c57514f7b2bd7d444c9e3051a717
 compiler/main/GHC.hs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/compiler/main/GHC.hs b/compiler/main/GHC.hs
index 1f7b117..f647960 100644
--- a/compiler/main/GHC.hs
+++ b/compiler/main/GHC.hs
@@ -302,7 +302,6 @@ import TcRnTypes
 import Packages
 import NameSet
 import RdrName
-import qualified HsSyn -- hack as we want to reexport the whole module
 import HsSyn
 import Type     hiding( typeKind )
 import Kind             ( tyConResKind )



More information about the ghc-commits mailing list