[commit: ghc] ghc-7.10: Suggest chmod 755 instead of 644 (70c2b17)

git at git.haskell.org git at git.haskell.org
Thu Oct 22 15:34:27 UTC 2015


Repository : ssh://git@git.haskell.org/ghc

On branch  : ghc-7.10
Link       : http://ghc.haskell.org/trac/ghc/changeset/70c2b176079c63ba5040220c9b59c25029ef8b79/ghc

>---------------------------------------------------------------

commit 70c2b176079c63ba5040220c9b59c25029ef8b79
Author: Ben Gamari <bgamari.foss at gmail.com>
Date:   Thu Oct 22 17:35:18 2015 +0200

    Suggest chmod 755 instead of 644
    
    Previous suggestion would clear executable bit, meaning directory
    couldn't be entered. Fixes #11003.
    
    Test Plan: Read message.
    
    Reviewers: austin, thomie, dfeuer
    
    Reviewed By: thomie, dfeuer
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D1350
    
    GHC Trac Issues: #11003


>---------------------------------------------------------------

70c2b176079c63ba5040220c9b59c25029ef8b79
 ghc/InteractiveUI.hs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ghc/InteractiveUI.hs b/ghc/InteractiveUI.hs
index 27343e9..ec82e3d 100644
--- a/ghc/InteractiveUI.hs
+++ b/ghc/InteractiveUI.hs
@@ -614,7 +614,7 @@ checkPerms name =
       -- #8248: Improving warning to include a possible fix.
       putStrLn $ "*** WARNING: " ++ name ++
                  " is writable by someone else, IGNORING!" ++
-                 "\nSuggested fix: execute 'chmod 644 " ++ name ++ "'"
+                 "\nSuggested fix: execute 'chmod go-w " ++ file ++ "'"
     return ok
 #endif
 



More information about the ghc-commits mailing list