[commit: ghc] wip/api-annots: ApiAnnotations : BooleanFormula construction discards original (3e655d5)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/api-annots
Link       : http://ghc.haskell.org/trac/ghc/changeset/3e655d52aebe87f957eb1ffd5697bd4f3300cd21/ghc

>---------------------------------------------------------------

commit 3e655d52aebe87f957eb1ffd5697bd4f3300cd21
Author: Alan Zimmerman <alan.zimm at gmail.com>
Date:   Fri May 8 12:05:06 2015 +0200

    ApiAnnotations : BooleanFormula construction discards original
    
    Summary:
    The MINIMAL pragma is captured in the parser using a BooleanFormula.
    
    The constructors (mkBool,mkAnd,mkOr) are smart and try to minimise the boolean formula as it is constructed.
    
    This discards the original information, making round tripping impossible.
    
    Note: there is another version which provides a more API Annotations friendly
    version of the MINIMAL pragma, but this requires changes to haddock, which will
    cause problems for 7.10.2.
    
    See https://github.com/alanz/ghc/tree/wip/10287
    
    Test Plan: ./validate
    
    Reviewers: hvr, austin
    
    Subscribers: Fuuzetsu, thomie, mpickering
    
    Differential Revision: https://phabricator.haskell.org/D837
    
    GHC Trac Issues: #10287
    
    Conflicts:
    	testsuite/tests/ghc-api/annotations/.gitignore
    	testsuite/tests/ghc-api/annotations/Makefile
    	testsuite/tests/ghc-api/annotations/all.T


>---------------------------------------------------------------

3e655d52aebe87f957eb1ffd5697bd4f3300cd21
 compiler/parser/Parser.y                           |  10 +-
 testsuite/tests/ghc-api/annotations/.gitignore     |   1 +
 testsuite/tests/ghc-api/annotations/Makefile       |   8 +
 .../tests/ghc-api/annotations/TestBoolFormula.hs   |  26 ++++
 testsuite/tests/ghc-api/annotations/all.T          |   1 +
 .../annotations/{t10268.hs => boolFormula.hs}      |   2 +-
 .../tests/ghc-api/annotations/boolFormula.stderr   |  17 +++
 .../tests/ghc-api/annotations/boolFormula.stdout   | 163 +++++++++++++++++++++
 8 files changed, 222 insertions(+), 6 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 3e655d52aebe87f957eb1ffd5697bd4f3300cd21