[commit: packages/process] master: Fix for GHC Trac 3649, comment 10 (3b4842d)

git at git.haskell.org git at git.haskell.org
Thu Mar 19 11:37:48 UTC 2015


Repository : ssh://git@git.haskell.org/process

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/3b4842d322574f2854aa4f2f4bb43b0a813d3e82/process

>---------------------------------------------------------------

commit 3b4842d322574f2854aa4f2f4bb43b0a813d3e82
Author: Michael Snoyman <michael at snoyman.com>
Date:   Tue Feb 17 16:30:14 2015 +0200

    Fix for GHC Trac 3649, comment 10


>---------------------------------------------------------------

3b4842d322574f2854aa4f2f4bb43b0a813d3e82
 cbits/runProcess.c | 4 +++-
 changelog.md       | 5 +++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/cbits/runProcess.c b/cbits/runProcess.c
index e6d7c77..f7828af 100644
--- a/cbits/runProcess.c
+++ b/cbits/runProcess.c
@@ -200,7 +200,9 @@ runInteractiveProcess (char *const args[],
             }
             // XXX Not the pipe
             for (i = 3; i < max_fd; i++) {
-                close(i);
+		if (i != forkCommunicationFds[1]) {
+		    close(i);
+		}
             }
         }
 
diff --git a/changelog.md b/changelog.md
index debfcaa..cb3a55f 100644
--- a/changelog.md
+++ b/changelog.md
@@ -1,5 +1,10 @@
 # Changelog for [`process` package](http://hackage.haskell.org/package/process)
 
+## Unreleased
+
+  * [Meaningful error message when exe not found on close\_fds is
+  True](https://ghc.haskell.org/trac/ghc/ticket/3649#comment:10)
+
 ## 1.2.2.0  *Jan 2015*
 
   * Fix delegated CTRL-C handling in `createProcess` in case of failed



More information about the ghc-commits mailing list