[commit: ghc] wip/d1141: Delete FastBool (e433505)

git at git.haskell.org git at git.haskell.org
Tue Aug 18 16:42:15 UTC 2015


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/d1141
Link       : http://ghc.haskell.org/trac/ghc/changeset/e43350573b7a6f233bc7ef2a8badaeb15fb46f34/ghc

>---------------------------------------------------------------

commit e43350573b7a6f233bc7ef2a8badaeb15fb46f34
Author: Thomas Miedema <thomasmiedema at gmail.com>
Date:   Tue Aug 18 18:38:12 2015 +0200

    Delete FastBool
    
    This reverses some of the work done in Trac #1405, and assumes GHC is
    smart
    enough to do its own unboxing of booleans now.
    
    I would like to do some more performance measurements, but the code
    changes can
    be reviewed already.
    
    Test Plan:
    With a perf build:
    ./inplace/bin/ghc-stage2 nofib/spectral/simple/Main.hs -fforce-recomp
    +RTS -t --machine-readable
    
    before:
      [("bytes allocated", "1300744864")
      ,("num_GCs", "302")
      ,("average_bytes_used", "8811118")
      ,("max_bytes_used", "24477464")
      ,("num_byte_usage_samples", "9")
      ,("peak_megabytes_allocated", "64")
      ,("init_cpu_seconds", "0.001")
      ,("init_wall_seconds", "0.001")
      ,("mutator_cpu_seconds", "2.833")
      ,("mutator_wall_seconds", "4.283")
      ,("GC_cpu_seconds", "0.960")
      ,("GC_wall_seconds", "0.961")
    
    after:
      [("bytes allocated", "1301088064")
      ,("num_GCs", "310")
      ,("average_bytes_used", "8820253")
      ,("max_bytes_used", "24539904")
      ,("num_byte_usage_samples", "9")
      ,("peak_megabytes_allocated", "64")
      ,("init_cpu_seconds", "0.001")
      ,("init_wall_seconds", "0.001")
      ,("mutator_cpu_seconds", "2.876")
      ,("mutator_wall_seconds", "4.474")
      ,("GC_cpu_seconds", "0.965")
      ,("GC_wall_seconds", "0.979")
      ]
    
    CPU time seems to be up a bit, but I'm not sure. Unfortunately CPU time
    measurements are rather noisy.
    
    Reviewers: austin, bgamari, rwbarton
    
    Differential Revision: https://phabricator.haskell.org/D1143
    
    GHC Trac Issues: #1405


>---------------------------------------------------------------

e43350573b7a6f233bc7ef2a8badaeb15fb46f34
 compiler/codeGen/CodeGen/Platform.hs               |   3 +-
 compiler/ghc.cabal.in                              |   1 -
 compiler/ghc.mk                                    |   1 -
 compiler/main/TidyPgm.hs                           |  37 ++--
 compiler/nativeGen/PPC/Instr.hs                    |   5 +-
 compiler/nativeGen/PPC/Regs.hs                     |   3 +-
 compiler/nativeGen/RegAlloc/Graph/TrivColorable.hs |   2 +-
 .../nativeGen/RegAlloc/Linear/SPARC/FreeRegs.hs    |   5 +-
 compiler/nativeGen/SPARC/Instr.hs                  |   5 +-
 compiler/nativeGen/SPARC/Regs.hs                   |  10 +-
 compiler/nativeGen/X86/CodeGen.hs                  |   3 +-
 compiler/nativeGen/X86/Instr.hs                    |   3 +-
 compiler/nativeGen/X86/Regs.hs                     |   3 +-
 compiler/utils/FastBool.hs                         |  70 --------
 includes/CodeGen.Platform.hs                       | 187 ++++++++++-----------
 15 files changed, 122 insertions(+), 216 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc e43350573b7a6f233bc7ef2a8badaeb15fb46f34


More information about the ghc-commits mailing list