[commit: ghc] master: sync-all: die for real when required repo is missing (101c3f7)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/101c3f77706df77f5ef7df68cb08437131ec3aa0/ghc

>---------------------------------------------------------------

commit 101c3f77706df77f5ef7df68cb08437131ec3aa0
Author: Thomas Miedema <thomasmiedema at gmail.com>
Date:   Tue Jun 17 18:25:33 2014 +0200

    sync-all: die for real when required repo is missing
    
    Since commit 0e17d4, the default "tag" is "-", not "". It is never
    undefined.


>---------------------------------------------------------------

101c3f77706df77f5ef7df68cb08437131ec3aa0
 sync-all | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/sync-all b/sync-all
index 7b9d220..d60e5c9 100755
--- a/sync-all
+++ b/sync-all
@@ -340,10 +340,6 @@ sub gitall {
         if ($command eq "get") {
             next if $remotepath eq "-"; # "git submodule init/update" will get this later
 
-            # Skip any repositories we have not included the tag for
-            if (not defined($tags{$tag})) {
-                $tags{$tag} = 0;
-            }
             if ($tags{$tag} == 0) {
                 next;
             }
@@ -366,8 +362,8 @@ sub gitall {
 
         my $git_repo_present = 1 if -e "$localpath/.git" || ($bare_flag && -d "$localpath");
         if (not $git_repo_present) {
-            if ($tag eq "") {
-                die "Required repo $localpath is missing";
+            if ($tag eq "-") {
+                die "Required repo $localpath is missing. Please first run './sync-all get'.\n";
             }
             else {
                  message "== $localpath repo not present; skipping";