[commit: ghc] master: Fix malformed `configure` script (2d324dd)

git at git.haskell.org git at git.haskell.org
Mon Dec 1 20:30:37 UTC 2014


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/2d324dd41d1c5ee5f9fd667d6cae48539e6279ba/ghc

>---------------------------------------------------------------

commit 2d324dd41d1c5ee5f9fd667d6cae48539e6279ba
Author: Herbert Valerio Riedel <hvr at gnu.org>
Date:   Mon Dec 1 21:30:10 2014 +0100

    Fix malformed `configure` script
    
    Don't pass empty string `[]` as "action-if-not-given" to `AC_ARG_ENABLE()`
    macro, as this would otherwise lead to an empty else-block in the resulting
    bash `configure` script. This bug was introduced via cb0a503a.
    
    This issue was pointed out by @christiaanb
    
    Reviewed By: christiaanb
    
    Differential Revision: https://phabricator.haskell.org/D545


>---------------------------------------------------------------

2d324dd41d1c5ee5f9fd667d6cae48539e6279ba
 aclocal.m4 | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/aclocal.m4 b/aclocal.m4
index 2aa55d7..6caa10a 100644
--- a/aclocal.m4
+++ b/aclocal.m4
@@ -2277,8 +2277,7 @@ AC_DEFUN([FP_BFD_SUPPORT], [
                         [],dnl bfd seems to work
                         [AC_MSG_ERROR([can't use 'bfd' library])])
             LIBS="$save_LIBS"
-        ],
-        []
+        ]
     )
 ])
 



More information about the ghc-commits mailing list