[commit: ghc] master: Eliminate some code duplication in x86 backend (genCCall32/64) (c80d238)

git at git.haskell.org git at git.haskell.org
Sun Aug 10 21:38:31 UTC 2014


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/c80d238162d97e0cab69510af8602c73bfaf6ef3/ghc

>---------------------------------------------------------------

commit c80d238162d97e0cab69510af8602c73bfaf6ef3
Author: Reid Barton <rwbarton at gmail.com>
Date:   Sun Aug 10 17:16:42 2014 -0400

    Eliminate some code duplication in x86 backend (genCCall32/64)
    
    Summary:
    No functional changes except in panic messages.
    
    These functions were identical except for
    - x87 operations in genCCall32
    - the fallback to genCCall32'/64'
    - "32" vs "64" in panic messages (one case was wrong!)
    - minor syntactic or otherwise non-functional differences.
    
    Test Plan:
    Ran "validate --no-dph --slow" before and after the change.
    Only differences were two tests that failed before the change but not after,
    further investigation revealed that those tests are in fact erratic.
    
    Reviewers: simonmar, austin
    
    Reviewed By: austin
    
    Subscribers: phaskell, simonmar, relrod, ezyang, carter
    
    Differential Revision: https://phabricator.haskell.org/D139


>---------------------------------------------------------------

c80d238162d97e0cab69510af8602c73bfaf6ef3
 compiler/nativeGen/X86/CodeGen.hs | 114 +++++---------------------------------
 1 file changed, 13 insertions(+), 101 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc c80d238162d97e0cab69510af8602c73bfaf6ef3


More information about the ghc-commits mailing list