[commit: ghc] : Iteration on dterei's metadata design (12148d9)

David Terei davidterei at gmail.com
Fri Jun 28 03:56:49 CEST 2013


Repository : http://darcs.haskell.org/ghc.git/

On branch  : 

https://github.com/ghc/ghc/commit/12148d91bc0b0ab68392491bd1c927d7a8698205

>---------------------------------------------------------------

commit 12148d91bc0b0ab68392491bd1c927d7a8698205
Author: Peter Wortmann <scpmw at leeds.ac.uk>
Date:   Fri Jun 21 17:23:00 2013 +0100

    Iteration on dterei's metadata design
    
    - MetaArgs is not needed, as variables are already meta data
    
    - Same goes for MetaVal - its only reason for existing seems to be to
      support LLVM's strange pretty-printing for meta-data annotations, and
      I feel that is better to keep the data structure clean and handle it in
      the pretty-printing instead.
    
    - Rename "MetaData" to "MetaAnnot". Meta-data is still meta-data when it
      is not associated with an expression or statement - for example compile
      unit data for debugging. I feel the old name was a bit misleading.
    
    - Make the renamed MetaAnnot a proper data type instead of a type alias
      for a pair.
    
    - Rename "MetaExpr" constructor to "MetaStruct". As the data is much more
      like a LLVM structure (not array, as it can contain values).
    
    - Fix a warning

 compiler/llvmGen/Llvm.hs                |  4 +--
 compiler/llvmGen/Llvm/AbsSyn.hs         | 20 +++--------
 compiler/llvmGen/Llvm/MetaData.hs       | 59 +++++----------------------------
 compiler/llvmGen/Llvm/PpLlvm.hs         | 33 +++++++++---------
 compiler/llvmGen/Llvm/Types.hs          |  1 +
 compiler/llvmGen/LlvmCodeGen/CodeGen.hs |  4 +--
 compiler/llvmGen/LlvmCodeGen/Regs.hs    | 26 +++++++--------
 7 files changed, 49 insertions(+), 98 deletions(-)


Diff suppressed because of size. To see it, use:

    git show 12148d91bc0b0ab68392491bd1c927d7a8698205



More information about the ghc-commits mailing list